Skip to content

Fix awkward TICKET_LABEL_CREATION_ALLOWED substitutions in start skill#81

Merged
sebastientaggart merged 1 commit into
devfrom
feature/start-template-grammar
Apr 9, 2026
Merged

Fix awkward TICKET_LABEL_CREATION_ALLOWED substitutions in start skill#81
sebastientaggart merged 1 commit into
devfrom
feature/start-template-grammar

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

The start skill template substituted {{TICKET_LABEL_CREATION_ALLOWED}} verbatim into narrative prose, producing awkward rendered sentences like "If label creation is allowed (false = true, case-insensitive)" and "unless {{TICKET_LABEL_CREATION_ALLOWED}} = true". Purely cosmetic, but confusing for readers of the generated skill files.

Changes:

  • sync.sh: apply_conditionals now treats 'false', 'no', and '0' (case-insensitive) as falsy, in addition to empty strings, so config values like TICKET_LABEL_CREATION_ALLOWED: false work intuitively in {{#if}} blocks.
  • skills/start.md: Replaced the two awkward label-creation passages (pool-resolution body and hard-rules bullet) with {{#if TICKET_LABEL_CREATION_ALLOWED}} / {{#if !TICKET_LABEL_CREATION_ALLOWED}} branches that read naturally in either configuration.
  • skills/submit-for-review.md: Reworded the "regardless of {{TICKET_LABEL_CREATION_ALLOWED}}" sentence to avoid substituting the raw value into prose.
  • Regenerated all adapter output files.

Issue #77

@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

  • [NOTE] The new falsy-string handling in sync.sh (treating false/no/0 as falsy in {{#if}} blocks) is a behavior change for any config value that is the literal string false; generated skill files in this PR confirm the intended effect.
  • [NOTE] The falsy-string match in apply_conditionals only covers false/no/0 (case-insensitive); values like off or disabled will still be treated as truthy, worth noting when documenting config semantics.

@sebastientaggart
sebastientaggart merged commit cdb4895 into dev Apr 9, 2026
2 checks passed
@sebastientaggart
sebastientaggart deleted the feature/start-template-grammar branch April 9, 2026 22:22
This was referenced Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant